简化 ovn eip 类型 #3107
Merged
简化 ovn eip 类型 #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongzhen-ma
reviewed
Aug 3, 2023
hongzhen-ma
reviewed
Aug 3, 2023
hongzhen-ma
reviewed
Aug 3, 2023
hongzhen-ma
approved these changes
Aug 4, 2023
|
确认 CI 都通过之后再合入 |
|
cleanup 大量失败，需要检查一下相关逻辑 |
ok 我再检查下 |
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Aug 4, 2023
This reverts commit 6ba997d.
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Aug 4, 2023
* 简化 ovn eip 类型 * support nat reuse lrp ip * fix const value * fix ecmp bfd static route * fix cleanup
sirkrypt0
added a commit
to sirkrypt0/kube-ovn
that referenced
this pull request
Oct 15, 2023
We change the check to not enqueue a VPC update when the DeletionTimestamp is zero. Previously, the VPC update would basically always be enqueued, as the DeletionTimestamp would be zero until it was scheduled for deletion. This lead to a huge amount of enqueued VPC updates and therefore a lot of Kubernetes API requests and load on the API. The logical not was removed in kubeovn#3107 which therefore introduced this bug. Signed-off-by: Tobias Kantusch <[email protected]>
1 task
sirkrypt0
added a commit
to sirkrypt0/kube-ovn
that referenced
this pull request
Oct 15, 2023
We change the check to not enqueue a VPC update when the DeletionTimestamp is zero. Previously, the VPC update would basically always be enqueued, as the DeletionTimestamp would be zero until it was scheduled for deletion. This lead to a huge amount of enqueued VPC updates and therefore a lot of Kubernetes API requests and load on the API. The logical not was removed in kubeovn#3107 which therefore introduced this bug. Signed-off-by: Tobias Kantusch <[email protected]>
oilbeater
pushed a commit
that referenced
this pull request
Oct 16, 2023
We change the check to not enqueue a VPC update when the DeletionTimestamp is zero. Previously, the VPC update would basically always be enqueued, as the DeletionTimestamp would be zero until it was scheduled for deletion. This lead to a huge amount of enqueued VPC updates and therefore a lot of Kubernetes API requests and load on the API. The logical not was removed in #3107 which therefore introduced this bug. Signed-off-by: Tobias Kantusch <[email protected]>
oilbeater
pushed a commit
that referenced
this pull request
Oct 16, 2023
We change the check to not enqueue a VPC update when the DeletionTimestamp is zero. Previously, the VPC update would basically always be enqueued, as the DeletionTimestamp would be zero until it was scheduled for deletion. This lead to a huge amount of enqueued VPC updates and therefore a lot of Kubernetes API requests and load on the API. The logical not was removed in #3107 which therefore introduced this bug. Signed-off-by: Tobias Kantusch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
修复 bfd 路由无法新增多个
修复 vpc 更新路由未触发
WHAT
🤖 Generated by Copilot at 9cae868
Refactor the code to use new and simplified types for ovn eip and vip scenarios. This improves the readability and consistency of the code and the e2e test, and aligns with the ovn terminology. The main changes are in
pkg/controller,pkg/daemon,pkg/apis,pkg/util, andtest/e2e.🤖 Generated by Copilot at 9cae868
HOW
🤖 Generated by Copilot at 9cae868
eip,lrp, andnode external gwtolrp,lsp, andnatin theOvnEipSpectype definition (link)Lrptype instead of the oldLrpUsingEiptype when creating or updating the ovn eip cr for the logical router port increateDefaultVpcLrpEipandhandleAddVpcExternalfunctions (link, link)Lsptype instead of the oldNodeExtGwUsingEiptype when creating, updating, or deleting the bare logical switch port for the eip inhandleAddOvnEip,handleUpdateOvnEip, andhandleDelOvnEipfunctions (link, link, link, link)Lrptype instead of the oldLrpUsingEiptype when deleting the logical router port for the eip inhandleDelOvnEipfunction (link)Viptype instead of the oldNatUsingViptype when getting the internal vip from the virtual ip lister inhandleAddOvnFip,handleUpdateOvnFip,handleAddOvnDnatRule, andhandleUpdateOvnDnatRulefunctions (link, link, link, link)Lsptype instead of the oldNodeExtGwUsingEiptype when listing or checking the node external ovn eips inreconcileCustomVpcBfdStaticRouteandcheckNodeGwNicInNsfunctions (link, link, link, link)Vip,Lrp, andLspinstead of the old typesNatUsingVip,LrpUsingEip, andNodeExtGwUsingEipin theutilpackage (link)Viptype instead of the oldNatUsingViptype when creating the ovn fip and dnat with the share eip vip in the e2e test (link, link)Lsptype instead of the oldNodeExtGwUsingEiptype when creating the ovn node-ext-gw type eip on each node in the e2e test (link)Viptype instead of the oldNatUsingViptype when creating the ovn fip with the fip eip vip in the e2e test (link)